netdev - Re: [PATCH] NET: Remove unneeded type cast in skb_truesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071105.163320.82203647.davem@davemloft.net>
Date:	Mon, 05 Nov 2007 16:33:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	chuck.lever@...cle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET: Remove unneeded type cast in skb_truesize_check()

From: Chuck Lever <chuck.lever@...cle.com>
Date: Mon, 05 Nov 2007 18:59:26 -0500

> If that's truly the case, document the requirement (perhaps using
> something the compiler itself can verify) instead of using a clever
> type cast trick.

Feel free to submit such a change.

> Here's the problem with leaving these little surprises in commonly used 
> kernel headers.  Suppose the developer of a network driver or network 
> file system that uses one of these headers wants to employ static code 
> analysis to identify issues introduced by new patches to their 
> subsystem.  The tool warnings generated in kernel headers are just 
> noise, and make using such code analysis difficult.

Here's the problem with submitting patches fixing non-bugs and
removing useful assertions from kernel.  I won't apply them.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html