lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 07 Nov 2007 16:15:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	chuck.lever@...cle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET: Remove unneeded type cast in skb_truesize_check()

From: Chuck Lever <chuck.lever@...cle.com>
Date: Wed, 07 Nov 2007 10:11:28 -0500

> The (int) type cast in that assertion is nothing more than a comment. 
> The compiler promotes that side of the comparison to match the type on 
> the right side, and the explicit type cast is entirely ignored.  So in 
> fact, my patch removed nothing but a mistaken assumption.  The assertion 
> behaves the same after my patch as it did before.

Then please post a patch that makes the assertion work
instead of removing it, by casting both branches of the
comparison to be signed.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists