netdev - Re: [PATCH 02/05] ipv6: RFC4214 Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200711091912.03419.netdev@axxeo.de>
Date:	Fri, 9 Nov 2007 19:12:02 +0100
From:	Ingo Oeser <netdev@...eo.de>
To:	YOSHIFUJI Hideaki /
	 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
Cc:	Fred.L.Templin@...ing.com, netdev@...r.kernel.org
Subject: Re: [PATCH 02/05] ipv6: RFC4214 Support

YOSHIFUJI Hideaki / 吉藤英明 schrieb:
> In article <39C363776A4E8C4A94691D2BD9D1C9A1029EDBF4@...-NW-7V2.nw.nos.boeing.com> (at Wed, 7 Nov 2007 10:52:47 -0800), "Templin, Fred L" <Fred.L.Templin@...ing.com> says:
> 
> > > > > > > +	if (((ipv4 >= 0x01000000) && (ipv4 < 0x0a000000)) ||
> > > > > > > +	    ((ipv4 >= 0x0b000000) && (ipv4 < 0x7f000000)) ||
> > > > > > > +	    ((ipv4 >= 0x80000000) && (ipv4 < 0xa9fe0000)) ||
> > > > > > > +	    ((ipv4 >= 0xa9ff0000) && (ipv4 < 0xac100000)) ||
> > > > > > > +	    ((ipv4 >= 0xac200000) && (ipv4 < 0xc0a80000)) ||
> > > > > > > +	    ((ipv4 >= 0xc0a90000) && (ipv4 < 0xc6120000)) ||
> > > > > > > +	    ((ipv4 >= 0xc6140000) && (ipv4 < 
> > > 0xe0000000))) eui[0] |=
> > > > > > > 0x2;
> 
> > Maybe it is I who did not understand. Can you suggest a clean solution?
> 
> You could write each element as LOOPBACK(), MULTICAST()
> etc.
> 	eui[0] = (!ZERONETO(a) &&
> 	          !PRIVATE_10(a) &&
> 		  !LINKLOCAL(a) &&
> 		  !PRIVATE_172(a) &&
> 		  !PRIVATE_192(a) &&
> 		  !NETICDEVBENCH(a) &&
> 		  !MULTICAST(a)) ? 2 : 0;

Oh, yes that's great! Now even *I* can read what this is all about 
without reading any RFC :-)

Please Fred, try to do it that way.


Best Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html