lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 10 Nov 2007 21:48:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH 2/4] Add missed tunnel64_err handler

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Fri, 09 Nov 2007 16:14:12 +0300

> The tunnel64_protocol uses the tunnel4_protocol's err_handler and
> thus calls the tunnel4_protocol's handlers.
> 
> This is not very good, as in case of (icmp) error the wrong error
> handlers will be called (e.g. ipip ones instead of sit) and this
> won't be noticed at all, because the error is not reported.
> 
> Was that made deliberately and I miss something?
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

This definitely was doing the wrong thing for the SIT
case, for example.  So this looks legitimate to me.

Patch applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists