lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 10 Nov 2007 21:53:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	chuck.lever@...cle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET: Fix skb_truesize_check() assertion

From: Chuck Lever <chuck.lever@...cle.com>
Date: Thu, 08 Nov 2007 11:59:19 -0500

> The intent of the assertion in skb_truesize_check() is to check
> for skb->truesize being decremented too much by other code,
> resulting in a wraparound below zero.
> 
> The type of the right side of the comparison causes the compiler to
> promote the left side to an unsigned type, despite the presence of an
> explicit type cast.  This defeats the check for negativity.
> 
> Ensure both sides of the comparison are a signed type to prevent the
> implicit type conversion.
> 
> Signed-off-by: Chuck Lever <chuck.lever@...cle.com>

Applied, thanks Chuck.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists