lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 10 Nov 2007 21:22:40 -0800 (PST)
From:	David Miller <>
Subject: Re: [PATCH 2/4] [TCP]: Fix reord detection due to snd_una covered

From: "Ilpo_Järvinen" <>
Date: Sat, 10 Nov 2007 12:56:00 +0200

> Fixes subtle bug like the one with fastpath_cnt_hint happening
> due to the way the GSO and hints interact. Because hints are not
> reset when just a GSOed skb is partially ACKed, there's no
> guarantee that the relevant part of the write queue is going to
> be processed in sacktag at all (skbs below snd_una) because
> fastpath hint can fast forward the entrypoint.
> This was also on the way of future reductions in sacktag's skb
> processing. Also future cleanups in sacktag can be made after
> this (in 2.6.25).
> This may make reordering update in tcp_try_undo_partial
> redundant but I'm not too sure so I left it there.
> Signed-off-by: Ilpo Järvinen <>

Thanks for discovering this.

Applied, thanks.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists