netdev - RE: [PATCH 01/01] ipv6: RFC4214 Support (v2.0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39C363776A4E8C4A94691D2BD9D1C9A1029EDC28@XCH-NW-7V2.nw.nos.boeing.com>
Date:	Tue, 13 Nov 2007 09:29:51 -0800
From:	"Templin, Fred L" <Fred.L.Templin@...ing.com>
To:	"Vlad Yasevich" <vladislav.yasevich@...com>
Cc:	<netdev@...r.kernel.org>,
	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
Subject: RE: [PATCH 01/01] ipv6: RFC4214 Support (v2.0)

Vlad, 

> -----Original Message-----
> From: Vlad Yasevich [mailto:vladislav.yasevich@...com] 
> Sent: Tuesday, November 13, 2007 9:00 AM
> To: Templin, Fred L
> Cc: netdev@...r.kernel.org; YOSHIFUJI Hideaki / 吉藤英明
> Subject: Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.0)
> 
> Hi Fred
> 
> Templin, Fred L wrote: 
> >>> +		return;
> >>> +	}
> >>> +
> >>>  	sit_add_v4_addrs(idev);
> >>>  
> >>>  	if (dev->flags&IFF_POINTOPOINT) {
> >>> @@ -2531,6 +2570,18 @@ static void addrconf_rs_timer(unsigned l
> >>>  		 *	Announcement received after solicitation
> >>>  		 *	was sent
> >>>  		 */
> >>> +
> >>> +		/* ISATAP (RFC4214) - schedule next RS/RA */
> >>> +		if (ifp->idev->dev->priv_flags & IFF_ISATAP) {
> >>> +			struct ip_tunnel *t  = 
> >> netdev_priv(ifp->idev->dev);
> >>> +			if (t->parms.i_key != INADDR_NONE) {
> >>> +				spin_lock(&ifp->lock);
> >>> +				ifp->probes = 0;
> >>> +				ifp->idev->if_flags &= 
> >> ‾(IF_RS_SENT|IF_RA_RCVD);
> >>> +				addrconf_mod_timer(ifp, AC_DAD, 
> >> t->parms.o_key*HZ);
> >>
> >> You are using a DAD timer to schedule RS?
> > 
> > I am using the DAD timer to re-DAD the link local, which
> > in turn schedules RS.
> > 
> 
> Why?  Seems to me that using the RS timer (AC_RS) gets you 
> everything you
> want and nothing you don't.  You set probes to 0, which marks 
> DAD complete,
> thus you don't do DAD.  You already have code in the 
> addrconf_rs_timer() to
> properly send the RS.  So, your patch to sending the RS is 
> much shorter if
> you use the AC_RS timer.
> 
> Am I missing something?

Probably not. "Re-DAD the link-local" just seemed to have a nice
ring about it, but if we don't need it we can just as well go straight
to the RS. I'll take a closer look to verify...

Thanks - Fred
fred.l.templin@...ing.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html