netdev - Re: [PATCH][NET] Convert init_timer into setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071113134340.GI3943@ghostprotocols.net>
Date:	Tue, 13 Nov 2007 11:43:40 -0200
From:	"Arnaldo Carvalho de Melo" <acme@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	xemul@...nvz.org, netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH][NET] Convert init_timer into setup_timer

Em Tue, Nov 13, 2007 at 05:34:21AM -0800, David Miller escreveu:
> From: Pavel Emelyanov <xemul@...nvz.org>
> Date: Tue, 13 Nov 2007 16:10:03 +0300
> 
> > Many-many code in the kernel initialized the timer->function 
> > and  timer->data together with calling init_timer(timer). There 
> > is already a helper for this. Use it for networking code.
> > 
> > The patch is HUGE, but makes the code 130 lines shorter 
> > (98 insertions(+), 228 deletions(-)).
> > 
> > Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> 
> I have no objection to this patch, but it is 2.6.25
> material for sure.

Agreed, Pavel, if you want please stick:

Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html