netdev - Re: [PATCH] PATCH 1/2 [SCHED 2.6.24]: Check subqueue status before calling hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071113.221439.225154441.davem@davemloft.net>
Date:	Tue, 13 Nov 2007 22:14:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	peter.p.waskiewicz.jr@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH] PATCH 1/2 [SCHED 2.6.24]: Check subqueue status before
 calling hard_start_xmit

From: Krishna Kumar <krkumar2@...ibm.com>
Date: Wed, 14 Nov 2007 11:34:12 +0530

> Hi Peter,
> 
> Peter wrote on 11/13/2007 11:14:50 PM:
> > @@ -134,7 +134,7 @@ static inline int qdisc_restart(struct net_device *dev)
> >  {
> >     struct Qdisc *q = dev->qdisc;
> >     struct sk_buff *skb;
> > -   int ret;
> > +   int ret = NETDEV_TX_BUSY;
> >  
> >     /* Dequeue packet */
> >     if (unlikely((skb = dev_dequeue_skb(dev, q)) == NULL))
> > @@ -145,7 +145,8 @@ static inline int qdisc_restart(struct net_device *dev)
> >     spin_unlock(&dev->queue_lock);
> >  
> >     HARD_TX_LOCK(dev, smp_processor_id());
> > -   ret = dev_hard_start_xmit(skb, dev);
> > +   if (!netif_subqueue_stopped(dev, skb))
> > +      ret = dev_hard_start_xmit(skb, dev);
> >     HARD_TX_UNLOCK(dev);
> 
> You could optimize this by getting HARD_TX_LOCK after the check. I
> assume that netif_stop_subqueue (from another CPU) would always be
> called by the driver xmit, and that is not possible since we hold
> the __LINK_STATE_QDISC_RUNNING bit. Does that sound correct?

I don't think this is a critical optimization at this time,
but something to certainly do along with the surgery
we'll undoubtedly be doing here in the future :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html