netdev - Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <473B27E1.7020502@oracle.com>
Date:	Wed, 14 Nov 2007 11:52:49 -0500
From:	Chuck Lever <chuck.lever@...cle.com>
To:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
CC:	nfs@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr)

YOSHIFUJI Hideaki / 吉藤英明 wrote:
> In article <20071113183126.5087.27810.stgit@...ray.1015granger.net> (at Tue, 13 Nov 2007 13:31:27 -0500), Chuck Lever <chuck.lever@...cle.com> says:
> 
>>  		   clp->rpc_ops->version,
>> -		   NIPQUAD(clp->cl_addr.sin_addr),
>> -		   ntohs(clp->cl_addr.sin_port),
>> +		   rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_ADDR),
>> +		   rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_PORT),
>>  		   atomic_read(&clp->cl_count),
> 
> Is this really safe?

What's unsafe about it?  rpc_peeraddr2str() is designed to be called 
this way.

View attachment "chuck.lever.vcf" of type "text/x-vcard" (270 bytes)