netdev - Re: Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071114.155551.93961946.davem@davemloft.net>
Date:	Wed, 14 Nov 2007 15:55:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	guichaz@...oo.fr, netdev@...r.kernel.org
Subject: Re: Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571
 tcp_remove_reno_sacks()

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Wed, 14 Nov 2007 15:32:58 +0200 (EET)

> [PATCH] [TCP] FRTO: Clear frto_highmark only after process_frto that uses it
> 
> I broke this in commit 3de96471bd7fb76406e975ef6387abe3a0698149.
> tcp_process_frto should always see a valid frto_highmark. An
> invalid frto_highmark (zero) is very likely what ultimately
> caused a seqno compare in tcp_frto_enter_loss to do the wrong
> leading to the LOST-bit leak.
> 
> Having LOST-bits integry ensured like done after commit
> 23aeeec365dcf8bc87fae44c533e50d0bb4f23cc won't hurt. It may
> still be useful in some other, possibly legimate, scenario.
> 
> Reported by Chazarain Guillaume <guichaz@...oo.fr>.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied.

Thanks for making such an incredibly thorough investigation
into this bug!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html