netdev - Re: [PATCH 1/2] SOCK: add raw drops counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071113.203040.67290528.davem@davemloft.net>
Date:	Tue, 13 Nov 2007 20:30:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org, dada1@...mosbay.com
Subject: Re: [PATCH 1/2] SOCK: add raw drops counter

From: Wang Chen <wangchen@...fujitsu.com>
Date: Wed, 14 Nov 2007 11:12:18 +0800

> Add raw drops counter for IPv4 in /proc/net/raw .
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied to net-2.6.25, but your patch a lot of whitespace
problems:

Adds trailing whitespace.
diff:9:  *	@sk_flags: %SO_LINGER (l_onoff), %SO_BROADCAST, %SO_KEEPALIVE, 
Adds trailing whitespace.
diff:19:  *	@sk_prot_creator: sk_prot of original sock creator (see ipv6_setsockopt, 
Adds trailing whitespace.
diff:23:  *	@sk_err_soft: errors that don't cause failure but are the cause of a 
Adds trailing whitespace.
diff:56:		atomic_inc(&sk->sk_drops);	
warning: 4 lines add whitespace errors.

I fixed it by hand this time, but please fix this yourself before
future submissions.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html