netdev - Re: [PATCH 4/6] e1000e: convert register test macros to functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071113.205424.71818344.davem@davemloft.net>
Date:	Tue, 13 Nov 2007 20:54:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	auke-jan.h.kok@...el.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH 4/6] e1000e: convert register test macros to functions

From: Auke Kok <auke-jan.h.kok@...el.com>
Date: Tue, 13 Nov 2007 15:11:28 -0800

> From: Joe Perches <joe@...ches.com>
> 
> Add functions for reg_pattern_test and reg_set_and check
> Changed macros to use these functions
> 
> Compiled x86, untested
> 
> Size decreased ~2K
> 
> old:
> 
> $ size drivers/net/e1000e/ethtool.o
>    text    data     bss     dec     hex filename
>   14461       0       0   14461    387d drivers/net/e1000e/ethtool.o
> 
> new:
> 
> $ size drivers/net/e1000e/ethtool.o
>    text    data     bss     dec     hex filename
>   12498       0       0   12498    30d2 drivers/net/e1000e/ethtool.o
> 
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

Applied to netdev-2.6, but I had to fix up the following
whitespace issues by hand:

Adds trailing whitespace.
diff:28:bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data, 
Adds trailing whitespace.
diff:33:	static const u32 test[] = 
warning: 2 lines add whitespace errors.

Please correct this before submission in the future.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html