netdev - Re: [PATCH 6/6] e1000: fix schedule while atomic when called from mii-tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071113.210031.09862973.davem@davemloft.net>
Date:	Tue, 13 Nov 2007 21:00:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	auke-jan.h.kok@...el.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH 6/6] e1000: fix schedule while atomic when called from
 mii-tool

From: Auke Kok <auke-jan.h.kok@...el.com>
Date: Tue, 13 Nov 2007 15:11:38 -0800

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> mii-tool can cause the driver to call msleep during nway reset,
> bugzilla.kernel.org bug 8430.  Fix by simply calling reinit_locked
> outside of the spinlock, which is safe from ethtool, so it should be
> safe from here.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

Looks good.

A bug fix, so queued to net-2.6, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html