netdev - Re: [PATCH 2/2] move unneeded data to initdata section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m13av7xtg1.fsf@ebiederm.dsl.xmission.com>
Date:	Thu, 15 Nov 2007 11:19:26 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	"Denis V. Lunev" <den@...ru>, "Denis V. Lunev" <den@...nvz.org>,
	davem@...emloft.net, containers@...ts.osdl.org,
	netdev@...r.kernel.org, clg@...ibm.com, benjamin.thery@...l.net
Subject: Re: [PATCH 2/2] move unneeded data to initdata section

Sam Ravnborg <sam@...nborg.org> writes:

> On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
>> 
>> nothing is discarded after module load. Though, I can be wrong. Could
>> you point me to the exact place?
> If __initdata is not discarded after module load then we should do it.
> There is no reason to waste __initdata RAM when the module is loaded.

Down at the bottom of sys_init_module we have:

	/* Drop initial reference. */
	module_put(mod);
	unwind_remove_table(mod->unwind_info, 1);

	module_free(mod, mod->module_init);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
	mod->module_init = NULL;
	mod->init_size = 0;
	mod->init_text_size = 0;
	mutex_unlock(&module_mutex);

	return 0;

Which frees the memory for the .init sections.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html