netdev - Re: [PATCH] r6040 various bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200711151957.57708.florian.fainelli@telecomint.eu>
Date:	Thu, 15 Nov 2007 19:57:57 +0100
From:	Florian Fainelli <florian.fainelli@...ecomint.eu>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] r6040 various bugfixes

Hello Stephen,

Le jeudi 15 novembre 2007, Stephen Hemminger a écrit :
> Looks good, thanks:
>
> There is a function to make this easier:
> > @@ -756,10 +803,8 @@ r6040_open(struct net_device *dev)
> >  	if (lp->switch_sig != ICPLUS_PHY_ID) {
> >  		/* set and active a timer process */
> >  		init_timer(&lp->timer);
> > -		lp->timer.expires = TIMER_WUT;
> >  		lp->timer.data = (unsigned long)dev;
> >  		lp->timer.function = &r6040_timer;
> > -		add_timer(&lp->timer);
>
> Could be:
> 	setup_timer(&lp->timer, r6040_timer, dev);
> 	if (lp->switch_sig != ICPLUS_PHY_ID)
> 		mod_timer(&lp->timer, jiffies + HZ);

I will send a fix later when I have tested your suggestion to use slightly 
larger buffer and skb_reserve(skb, NET_IP_ALIGN).

Thank you.
-- 
Florian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html