netdev - Re: [PATCH 2.6.25] add bnx2x driver for BCM57710

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2007 15:10:17 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	eliezert@...adcom.com, netdev@...r.kernel.org, jeff@...zik.org,
	masbock@...ibm.com, eilong@...adcom.com, mchan@...adcom.com,
	linuxram@...ibm.com, poswald@...ell.com
Subject: Re: [PATCH 2.6.25] add bnx2x driver for BCM57710 - bnx2x.c

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Thu, 15 Nov 2007 15:03:49 -0800

> 1. Please use dev_err() to help user figure out which board has problem:
> Not:
> 		printk(KERN_ERR PFX "Cannot register net device\n");
> Instead:
> 		dev_err(&pdev->dev, "cannot register net device\n");
 ...

Stephen, thanks for the feedback.

My plan is to add today's submitted BNX2X driver as-is, so any of
these fixups should be submitted relative to that.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html