netdev - Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1IsZHx-0006Kv-00@gondolin.me.apana.org.au>
Date:	Thu, 15 Nov 2007 15:37:25 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	andi@...stfloor.org (Andi Kleen)
Cc:	dada1@...mosbay.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

Andi Kleen <andi@...stfloor.org> wrote:
>
> A cheaper change might have been to just limit the number of buckets
> scanned.

Actually the whole point of moving it out to process context
is so that we don't have to worry about keeping track of the number
of buckets since deciding on how many buckets to process is black
magic.

IMHO preemption is the answer :) But failing that, a resched
is the next best thing.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html