netdev - Re: Null pointer dereference in nf_nat_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2007 16:02:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	johnpol@....mipt.ru, cebbert@...hat.com,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Null pointer dereference in nf_nat_move_storage(), kernel
 2.6.23.1

From: Patrick McHardy <kaber@...sh.net>
Date: Fri, 16 Nov 2007 01:00:22 +0100

> David Miller wrote:
> > From: Evgeniy Polyakov <johnpol@....mipt.ru>
> > Date: Thu, 15 Nov 2007 15:06:59 +0300
> >
> >> Please test attached patch.
> >>
> >> This routing is called each time hash should be replaced, nf_conn has
> >> extension list which contains pointers to connection tracking users
> >> (like nat, which is right now the only such user), so when replace takes
> >> place it should copy own extensions. Loop above checks for own
> >> extension, but tries to move higer-layer one, which can lead to above
> >> oops.
> >>
> >> Not tested, derived from code observation only.
> >>
> >> Signed-off-by: Evgeniy Polyakov <johnpol@....mipt.ru>
> >
> > It looks extremely correct to me.  Therefore I'm going to apply
> > this and queue it up for -stable.
> >
> > Thanks Evgeniy, keep up the excellent work!
> >
> > Patrick, please let me know if you have any objections.
> 
> The patch looks fine, thanks. I was just waiting for confirmation
> from Chuck.

I have to hold off the -stable submission until it hits
Linus's tree anyways, so I'll make sure we see test feedback
by that time as well.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html