lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Nov 2007 20:05:20 -0800 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: "Jon Nelson" <jnelson@...poni.net> Cc: "Jarek Poplawski" <jarkao2@...pl>, "Andrew Morton" <akpm@...ux-foundation.org>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, jnelson-kernel-bugzilla@...poni.net Subject: Re: [PATCH] via-velocity: don't oops on MTU change. On Thu, 15 Nov 2007 20:42:55 -0600 "Jon Nelson" <jnelson@...poni.net> wrote: > On 11/15/07, Jarek Poplawski <jarkao2@...pl> wrote: > .. > > > Sure! I was only worried velocity_open() treats dev->mtu > > a bit different than velocity_change_mtu(), so eg. after: > > > > velocity_change_mtu() // dev is down > > velocity_open() > > velocity_change_mtu() // dev is up > > > > with the same mtu, vptr->rx_buf_sz could be different than after: > > > > velocity_open() > > velocity_change_mtu() // dev is up > > > > But, probably, I miss someting. > > There is a snag here: if I change the MTU after the device is UP > something ends up rather broken. A tcpdump shows nearly every outgoing > frame has a bad TCP checksum (and the card does not support H/W > checksumming or it is turned off as reported by ethtool). > That is a different (and pre-existing bug). -- Stephen Hemminger <shemminger@...ux-foundation.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists