netdev - Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071116.232455.82345485.yoshfuji@linux-ipv6.org>
Date:	Fri, 16 Nov 2007 23:24:55 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	xemul@...nvz.org
Cc:	davem@...emloft.net, netdev@...r.kernel.org, devel@...nvz.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

NAK.

In article <473DA6EF.5090004@...nvz.org> (at Fri, 16 Nov 2007 17:19:27 +0300), Pavel Emelyanov <xemul@...nvz.org> says:

> @@ -858,7 +852,7 @@ static struct sock *raw_get_first(struct seq_file *seq)
>  			++state->bucket) {
>  		struct hlist_node *node;
>  
> -		sk_for_each(sk, node, &raw_v4_hashinfo.ht[state->bucket])
> +		sk_for_each(sk, node, &state->h->ht[state->bucket])
>  			if (sk->sk_family == PF_INET)
>  				goto found;
>  	}

This and

> -static struct sock *raw6_get_first(struct seq_file *seq)
> -{
> -	struct sock *sk;
> -	struct hlist_node *node;
> -	struct raw6_iter_state* state = raw6_seq_private(seq);
> -
> -	for (state->bucket = 0; state->bucket < RAW_HTABLE_SIZE;
> -			++state->bucket)
> -		sk_for_each(sk, node, &raw_v6_hashinfo.ht[state->bucket])
> -			if (sk->sk_family == PF_INET6)
> -				goto out;
> -	sk = NULL;
> -out:
> -	return sk;
> -}
> -

this are different.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html