netdev - Re: [PATCH 2/7] CAN: Add PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ygfr6iqmfa3.fsf@janus.isnogud.escape.de>
Date:	16 Nov 2007 15:33:08 +0100
From:	Urs Thuermann <urs.thuermann@....de>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, oliver@...tkopp.net,
	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	kaber@...sh.net, oliver.hartkopp@...kswagen.de
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module

David Miller <davem@...emloft.net> writes:

> I really frown upon these local debugging macros people tend to want
> to submit with their changes.
> 
> It really craps up the tree, even though it might be useful to you.

We have now removed the debug code completely.  The code is quite
stable and we won't need these remnants from early days anymore.

> So please remove this stuff or replace the debugging statements
> with some generic kernel debugging facility, there are several.

I am not aware of any useful kernel facilities to replace our debug
macros, i.e. printing of debug messages, controlled by a bit mask
passed in as a module parameter, hexdumping of fames, etc.  Of course,
there are other things like kprobes but sometimes printk(KERN_DEBUG...)
is more convenient and that's why people write their own DBG() macros.

urs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html