netdev - Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <473DAD42.60603@trash.net>
Date:	Fri, 16 Nov 2007 15:46:26 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	Joonwoo Park <joonwpark81@...il.com>, netdev@...r.kernel.org,
	'David Miller' <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, greearb@...delatech.com, w@....eu,
	cfriesen@...tel.com, djohnson+linux-kernel@...starentnetworks.com,
	e1000-devel@...ts.sourceforge.net,
	"'Kok, Auke'" <auke-jan.h.kok@...el.com>
Subject: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous
 mode

Herbert Xu wrote:
> BTW, how does the VLAN TX acceleration work at all? It's using
> skb->cb to carry the tags but then calls dev_queue_xmit.  Once
> you do that packet schedulers can scribble all over skb->cb.
> 
> Also vlan_skb_recv should be moved out-of-line.  It's absolutely
> humongous.  It'll generate tail-calls anyway so performance-wise
> it's useless.


I have a number of VLAN cleanups queued and intend to do these
two changes on top.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html