netdev - Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Nov 2007 00:03:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	horms@...ge.net.au, netdev@...r.kernel.org, pekkas@...core.fi,
	kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, jmorris@...ei.org,
	kaber@...eworks.de
Subject: Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to
 inline functions

From: Joe Perches <joe@...ches.com>
Date: Mon, 19 Nov 2007 23:18:44 -0800

> On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote:
> > Also, as the function names are longer than the macro name
> > you are creating lines that are > 80 columns wide that used
> > not to be in that state. For my eyes that reduced readability
> > (substantially).
> 
> David? You want a patch for that too?

These patches are just clumsy and awkward, this much I will
say.

BTW, these seemingly odd macro names come from BSD.
Terefore they are quite readable for many of us :-)

I don't know what to do with these patches, they feel like
just plain noise to me even though I like the type checking.

I'm going to defer for now, sorry.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html