netdev - Re: [PATCH] LRO ack aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071120135056.GA18266@gondor.apana.org.au>
Date:	Tue, 20 Nov 2007 21:50:56 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	Andrew Gallatin <gallatin@...i.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	ossthema@...ibm.com
Subject: Re: [PATCH] LRO ack aggregation

On Tue, Nov 20, 2007 at 04:35:09PM +0300, Evgeniy Polyakov wrote:
> 
> On Tue, Nov 20, 2007 at 08:27:05AM -0500, Andrew Gallatin (gallatin@...i.com) wrote:
> > Hmm.. rather than a global tunable, what if it was a
> > network driver managed tunable which toggled a flag in the
> > lro_mgr features?  Would that be better?
> 
> What about ethtool control to set LRO_simple and LRO_ACK_aggregation?

I have two concerns about this:

1) That same option can still be turned on by distros.
2) This doesn't make sense because the code is actually in the
   core networking stack.

I'm particular unhappy about 2) because I don't want be in a
situation down the track where every driver is going to add this
option so that they're not left behind in the arms race.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html