netdev - Re: [PATCH] LRO ack aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071120140831.GA18465@gondor.apana.org.au>
Date:	Tue, 20 Nov 2007 22:08:31 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	Andrew Gallatin <gallatin@...i.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	ossthema@...ibm.com
Subject: Re: [PATCH] LRO ack aggregation

On Tue, Nov 20, 2007 at 05:03:12PM +0300, Evgeniy Polyakov wrote:
> 
> For software lro I agree, but this looks exactly like gso/tso case and
> additional tweak for software gso. Having it per-system is fine, and I
> believe no one should ever care that some distro will do bad/good things
> with it. Actually we do have so much tricky options in procfs already
> which can kill performance...

Right, if you're doing it such that the same option automatically
shows up for every driver that uses software LRO then my second
concern goes away.

Of course we still have the problem with the option in general
that Dave raised.  That is this may cause the proliferation of
TCP receiver behaviour that may be undesirable.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html