netdev - Re: [PATCH 09/11] netpoll: ethernet devices only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071119.195515.54073365.davem@davemloft.net>
Date:	Mon, 19 Nov 2007 19:55:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	satyam@...radead.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/11] netpoll: ethernet devices only

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Sat, 03 Nov 2007 11:43:23 -0700

> Netpoll only works on Ethernet devices, so check during setup
> rather than just failing silently later.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> 
> --- a/net/core/netpoll.c	2007-11-03 11:05:33.000000000 -0700
> +++ b/net/core/netpoll.c	2007-11-03 11:08:23.000000000 -0700
> @@ -653,6 +653,12 @@ int netpoll_setup(struct netpoll *np, st
>  	unsigned long flags;
>  	int err;
>  
> +	if (ndev->type != ARPHRD_ETHER) {
> +		printk(KERN_ERR "netpoll: %s is not an ethernet device\n",
> +		       ndev->name);
> +		return -EINVAL;
> +	}
> +
>  	np->dev = ndev;

This patch depends upon the broken np->dev_name one, and I also would
rather fix the limitations in netpoll.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html