netdev - Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071119.214655.247082473.davem@davemloft.net>
Date:	Mon, 19 Nov 2007 21:46:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlstevens@...ibm.com
Cc:	joe@...ches.com, jmorris@...ei.org, kaber@...eworks.de,
	kuznet@....inr.ac.ru, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, pekkas@...core.fi,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class
 macros to inline functions

From: David Stevens <dlstevens@...ibm.com>
Date: Wed, 14 Nov 2007 08:53:13 -0800

> Maybe I'm more used to hex, but I personally don't think those are
> more readable. It replaces 1-line macroes with 4-line functions, and
> I think more vgrepping to pick out the relevant constant data.

Yes, the readability is agruable but I like the type checking.

I would also change the names, it's a better idea to prefix the
names with a namespace for the stuff being operated on, therefore
I'd prefer names like "ipv4_is_loopback()" etc.

I'm dropping these patches for now.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html