[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20071119.224357.33938372.davem@davemloft.net>
Date: Mon, 19 Nov 2007 22:43:57 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: dada1@...mosbay.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from
softirq to workqueue
From: Eric Dumazet <dada1@...mosbay.com>
Date: Sat, 17 Nov 2007 10:41:47 +0100
> [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue
>
> Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole
> ip route cache is triggered. On loaded machines, this can starve softirq for
> many seconds and can eventually crash.
>
> This patch moves this flush to a workqueue context, using the worker we
> intoduced in commit 39c90ece7565f5c47110c2fa77409d7a9478bd5b
> (IPV4: Convert rt_check_expire() from softirq processing to workqueue.)
>
> Also, immediate flushes (echo 0 >/proc/sys/net/ipv4/route/flush) are using
> rt_do_flush() helper function, wich take attention to rescheduling.
>
> Next step will be to handle delayed flushes
> ("echo -1 >/proc/sys/net/ipv4/route/flush" or
> "ip route flush cache")
>
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
Applied, thanks Eric.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists