netdev - Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071120.174125.222831634.davem@davemloft.net>
Date:	Tue, 20 Nov 2007 17:41:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Fred.L.Templin@...ing.com
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	vladislav.yasevich@...com
Subject: Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.4)

From: David Miller <davem@...emloft.net>
Date: Tue, 20 Nov 2007 17:34:59 -0800 (PST)

> I think we've made Fred jump through enough hoops :-)
> I've added this to net-2.6.25, any fixups should be
> sent relative to this, thanks.

Actually, I'm reverting, the patch doesn't even compile:

net/ipv6/addrconf.c: In function 'ipv6_add_dev':
net/ipv6/addrconf.c:381: error: 'IFF_ISATAP' undeclared (first use in this function)
net/ipv6/addrconf.c:381: error: (Each undeclared identifier is reported only once
net/ipv6/addrconf.c:381: error: for each function it appears in.)
net/ipv6/addrconf.c: In function 'ipv6_generate_eui64':
net/ipv6/addrconf.c:1420: error: 'IFF_ISATAP' undeclared (first use in this function)
net/ipv6/addrconf.c: In function 'addrconf_sit_config':
net/ipv6/addrconf.c:2188: error: 'IFF_ISATAP' undeclared (first use in this function)

Please don't waste developer time like this, test the patches you
submit so that they at least apply cleanly _and_ compile.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html