lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Nov 2007 17:06:42 +1100 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: <jgarzik@...ox.com> CC: <netdev@...r.kernel.org>, <linuxppc-dev@...abs.org>, Josh Boyer <jwboyer@...ux.vnet.ibm.com> Subject: [PATCH 4/8] ibm_newemac: Fix ZMII refcounting bug When using ZMII for MDIO only (such as 440GX with RGMII for data and ZMII for MDIO), the ZMII code would fail to properly refcount, thus triggering a BUG_ON(). Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org> Acked-by: Stefan Roese <sr@...x.de> --- drivers/net/ibm_newemac/zmii.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux-work/drivers/net/ibm_newemac/zmii.c =================================================================== --- linux-work.orig/drivers/net/ibm_newemac/zmii.c 2007-11-08 15:45:32.000000000 +1100 +++ linux-work/drivers/net/ibm_newemac/zmii.c 2007-11-08 15:46:21.000000000 +1100 @@ -83,12 +83,14 @@ int __devinit zmii_attach(struct of_devi ZMII_DBG(dev, "init(%d, %d)" NL, input, *mode); - if (!zmii_valid_mode(*mode)) + if (!zmii_valid_mode(*mode)) { /* Probably an EMAC connected to RGMII, * but it still may need ZMII for MDIO so * we don't fail here. */ + dev->users++; return 0; + } mutex_lock(&dev->lock); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists