netdev - Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071121094350.44a18e26@weaponx>
Date:	Wed, 21 Nov 2007 09:43:50 -0600
From:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	netdev@...r.kernel.org, jgarzik@...ox.com, linuxppc-dev@...abs.org
Subject: Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

On Wed, 21 Nov 2007 16:41:23 +0100
Christoph Hellwig <hch@....de> wrote:

> On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote:
> > It's a bad idea to call flush_scheduled_work from within a
> > netdev->stop because the linkwatch will occasionally take the
> > rtnl lock from a workqueue context, and thus that can deadlock.
> > 
> > This reworks things a bit in that area to avoid the problem.
> 
> So from the name of the driver you want to keep the previous emac
> driver around.  Is there a good reason for that?

It's being kept around until arch/ppc dies.  Then things should get
renamed.

josh
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html