netdev - Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A8AEF70B-2B76-4F62-A930-ABCA9E9E7475@freescale.com>
Date:	Wed, 21 Nov 2007 11:54:47 -0600
From:	Andy Fleming <afleming@...escale.com>
To:	Herbert Valerio Riedel <hvr@....org>
Cc:	netdev@...r.kernel.org, Lennert Buytenhek <buytenh@...tstofly.org>
Subject: Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework


On Nov 16, 2007, at 03:38, Herbert Valerio Riedel wrote:

> Currently, the ep93xx_eth driver doesn't care about the PHY state,
> but it should, in order to tell the MAC when full duplex operation is
> required; failure to do so causes degraded performance on full duplex
> links. This patch implements proper PHY handling via the phylib  
> framework:
>
>  - clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
>  - convert ep93xx_eth driver to phylib framework
>  - set full duplex bit in configuration of MAC when FDX link detected
>  - convert to use print_mac()

Looks good to me.  My only comment is that we might want to have  
support for checking preamble suppression support in the PHY Lib,  
itself.

Acked-by: Andy Fleming <afleming@...escale.com>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html