netdev - Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071122.185914.17090750.takano@axe-inc.co.jp>
Date:	Thu, 22 Nov 2007 18:59:14 +0900 (JST)
From:	TAKANO Ryousei <takano@...-inc.co.jp>
To:	dada1@...mosbay.com
Cc:	takano-ryousei@...t.go.jp, netdev@...r.kernel.org,
	shemminger@...ux-foundation.org, t.kudoh@...t.go.jp
Subject: Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

Hi Eric,

> > +static struct sk_buff *alloc_gap_packet(struct Qdisc* sch, int size)
> > +{
> > +	struct sk_buff *skb;
> > +	struct net_device *dev = sch->dev;
> > +	unsigned char *pkt;
> > +	int pause_time = 0;
> > +	int pktsize = size + 2;
> > +
> > +	skb = alloc_skb(pktsize, GFP_ATOMIC);
> > +	if (!skb)
> > +		return NULL;
> > +
> > +	skb_reserve(skb, 2);
> 
> minor nit, but skb_reserve is not *needed* here.
> 
> skb_reserve() is used to align IP header on a 16 bytes boundary, and
> we do it on rx side to speedup IP stack, at the cost of a possibly more
> expensive DMA transfert.
> 
> Here you dont send an IP packet, do you ?
> 
Yes, I send not an IP packet but an Ethernet frame. I removed it
and confirmed to work. Thanks for your comment.

Best regards,
Ryousei Takano
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html