lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Nov 2007 19:00:46 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> Cc: John Heffner <jheffner@....edu>, netdev@...r.kernel.org Subject: Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop) On Wed, Nov 21, 2007 at 06:01:28PM +0200, Ilpo Järvinen wrote: > The original code has striking complexity to perform a query > which can be reduced to a very simple compare. > > FIN seqno may be included to write_seq but it should not make > any significant difference here compared to skb->len which was > used previously. One won't end up there with SYN still queued. > > Use of write_seq check guarantees that there's a valid skb in > send_head so I removed the extra check. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> OK, this one looks pretty straightforward. I'll put it in once we resolve the other patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists