netdev - Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Nov 2007 16:14:03 +0200 (EET)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Herbert Xu <herbert@...dor.apana.org.au>
cc:	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue
 abstraction funcs

On Fri, 23 Nov 2007, Herbert Xu wrote:

> On Fri, Nov 23, 2007 at 02:25:08PM +0200, Ilpo Järvinen wrote:
> > 
> > Better place exists in update_send_head (other non-queue related
> > adjustments are done there as well) which is the only caller of
> > tcp_advance_send_head (now that the bogus call from mtu_probe is
> > gone).
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> 
> Hmm, why don't we just get rid of tcp_advance_send_head?
> Or are you planning to start using it again?

The purpose of the tcp_advance_send_head & friends was/is to abstract
the write queue from the TCP worker code. RB-tree wq can then be put in 
place more easily (and I'm hopefully coming to that soon). There are some 
other similar functions in tcp.h as well which currently have only a 
single caller. Please don't undo that work while DaveM is away for a short 
while :-).

IMHO it was a mistake from my side to add frto code into the wq abstaction 
function in the first place though I could use the bogus call that 
tcp_mtu_probe used to make there as an excuse :-), the TCP worker code is 
much better place for it (and it does similar stuff already)...

-- 
 i.