lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Nov 2007 21:51:02 +0300 From: Evgeniy Polyakov <johnpol@....mipt.ru> To: Matt Mackall <mpm@...enic.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Simon Arlott <simon@...e.lp0.eu>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Ingo Molnar <mingo@...hat.com> Subject: Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable() On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov (johnpol@....mipt.ru) wrote: > Stop, we are trying to free skb without destructor and catch connection > tracking, so it is not a solution. To fix the problem we need to check > if it is not netfilter related, kind of this (not tested), Simon please > give it a try: And to be really cool we need to bypass skbs with xfrm attached, since its freeing also assumes BH context. Signed-off-by: Evgeniy Polyakov <johnpol@....mipt.ru> diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 758dafe..5f86e60 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -196,7 +196,8 @@ static void zap_completion_queue(void) while (clist != NULL) { struct sk_buff *skb = clist; clist = clist->next; - if (skb->destructor) + if (skb->destructor || skb->nfct || + skb->nfct_reasm || skb->sp) dev_kfree_skb_any(skb); /* put this one back */ else __kfree_skb(skb); -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists