netdev - cqe, cqe_skb: return when both or when either NULL?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Nov 2007 22:54:17 +0100
From:	Roel Kluin <12o3l@...cali.nl>
To:	netdev@...r.kernel.org, themann@...ibm.com
Subject: cqe, cqe_skb: return when both or when either NULL?

In function ehea_poll() drivers/net/ehea/ehea_main.c:667, in a loop cqe and
cqe_skb - both struct ehea_cqe pointers - are assigned:
--
cqe = ehea_poll_rq1(pr->qp, &wqe_index);
cqe_skb = ehea_poll_cq(pr->send_cq);

if (!cqe && !cqe_skb)
	return rx;
--
Is it intended that only when both are NULL there is a return, or should there
be returned when either is NULL (and the && replaced with ||).

If the code is ok as is, sorry for the noise.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html