netdev - Re: [patch 3/8] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Nov 2007 18:04:58 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, Emilian.Medve@...escale.com,
	davem@...emloft.net, galak@...e.crashing.org, leoli@...escale.com,
	paulus@...ba.org
Subject: Re: [patch 3/8]
 ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

On Fri, 23 Nov 2007 20:58:51 -0500 Jeff Garzik <jeff@...zik.org> wrote:

> akpm@...ux-foundation.org wrote:
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Emil Medve <Emilian.Medve@...escale.com>
> > Cc: Jeff Garzik <jeff@...zik.org>
> > Cc: Kumar Gala <galak@...e.crashing.org>
> > Cc: Li Yang <leoli@...escale.com>
> > Cc: Paul Mackerras <paulus@...ba.org>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > ---
> > 
> >  drivers/net/ucc_geth.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff -puN drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes drivers/net/ucc_geth.c
> > --- a/drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes
> > +++ a/drivers/net/ucc_geth.c
> > @@ -3443,7 +3443,7 @@ static int ucc_geth_rx(struct ucc_geth_p
> >  	u16 length, howmany = 0;
> >  	u32 bd_status;
> >  	u8 *bdBuffer;
> > -	struct net_device * dev;
> > +	struct net_device *dev;
> 
> ACK with a fixed description...
> 

Well...  I do these little fixups

a) to remind originators that they should be checking their stuff with
checkpatch

b) to fold into the offending base patch prior to sending upstream

c) to let upstream (in this case you) know that the patch had coding-style
problems.

as it appears that you merged the base patch without noticing the error,
and without running checkpatch I don't think it's worth merging a silly
one-liner like this on its own.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html