netdev - RE: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Nov 2007 00:48:31 -0500
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
To:	"Jeff Garzik" <jeff@...zik.org>,
	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>
Cc:	<netdev@...r.kernel.org>, "support" <support@...erion.com>
Subject: RE: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

Jeff,

We got an ACK back last week from Dave Miller that the following 2
patches were already applied - reply follows.

" > [Ram] The version numbers are different for the 2 patches. Was the 
> MSI-X leak bug fix applied prior to resubmission (we had swapped the 
> version numbers on the patches for resubmission).
> 
> [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry

> memories when vector allocation fails
> +#define DRV_VERSION "2.0.26.6"
> 
> [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet 
> addresses
> +#define DRV_VERSION "2.0.26.7"

I applied only the leak fix to the stable branch, and only the ethernet
address support patch to the 2.6.25 development tree.

The bug fix will show up later when the 2.6.25 development tree gets
rebased to upstream (which will have the leak fix by then).

This is how I do things, and that's why changing the DRV_VERSION to
2.0.26.7 made no sense.

Therefore it makes the most sense to bump driver version numbers only
when things are entirely self contained."

Ram
> -----Original Message-----
> From: Jeff Garzik [mailto:jeff@...zik.org]
> Sent: Friday, November 23, 2007 7:03 PM
> To: Sreenivasa Honnur
> Cc: netdev@...r.kernel.org; support
> Subject: Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing
MSI-X
> local entry memories when vector allocation fails
> 
> Sreenivasa Honnur wrote:
> > - Fixed memory leak by freeing MSI-X local entry memories when
vector
> allocation
> > fails in s2io_add_isr.
> > - Added two utility functions remove_msix_isr and remove_inta_isr to
> eliminate
> > code duplication.
> > - Incorporated following review comments from Jeff
> >         - Removed redundant stats->mem_freed and synchronize_irq
call
> >         - do_rem_msix_isr is renamed as remove_msix_isr
> >         - do_rem_inta_isr is renamed as remove_inta_isr
> >
> > - (Resubmit third time)
> 
> ditto, does not apply
> 

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html