netdev - Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071125230524.GC21363@electric-eye.fr.zoreil.com>
Date:	Mon, 26 Nov 2007 00:05:24 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Martin Michlmayr <tbm@...ius.com>
Cc:	netdev@...r.kernel.org, Edward Hsu <edward_hsu@...ltek.com.tw>,
	bunk@...sta.de
Subject: Re: [PATCH 12/21] r8169: confusion between hardware and IP header
	alignment

Martin Michlmayr <tbm@...ius.com> :
[...]
> I'd like to backport the fix to the 2.6.18 kernel that is in our
> stable release and have a couple of questions:
>  - Does your later patch "align the IP header when there is no DMA
>    constraint" fix any bugs or is it merely an improvement?

It fixes a "it was faster before" problem.

>  - Should I change "align" to 8 for RTL_CFG_1, as it's done in
>    current kernels?

No. RTL_CFG_1 is for the 8168 (slightly different beast).

> I'd like to backport only the changes needed to actually fix the bug
> in order to make sure I won't break any other devices.  The patch
> below works for me but I'd like to hear your opinion about my
> questions above.

If you have 6dccd16b7c2703e8bbf8bca62b5cf248332afbe2 applied, you
want c946b3047205d7e107be16885bbb42ab9f10350a too.

[...]
> Some background: the Thecus N2100 is an ARM based NAS device with two
> 8169 ports. The chips exhibit PCI parity problems so
> dev->broken_parity_status is set on this platform.

I remember it.

If you move from the 8110SB to the 8110SC, you will probably want to apply
65d916d95314566f426cc40ff0f17b754a773b0b

Btw, could you send me a dmesg from a recent kernel ? I'd like to keep a
trace of the XID value for your device.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html