lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Nov 2007 15:15:12 -0800 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Jeff Garzik <jgarzik@...ox.com> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>, auke-jan.h.kok@...el.com, netdev@...r.kernel.org, linuxppc-dev@...abs.org Subject: Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources Jeff Garzik wrote: > Benjamin Herrenschmidt wrote: >> The e1000 driver stores the content of the PCI resources into >> unsigned long's before ioremapping. This breaks on 32 bits >> platforms that support 64 bits MMIO resources such as ppc 44x. >> >> This fixes it by removing those temporary variables and passing >> directly the result of pci_resource_start/len to ioremap. >> >> The side effect is that I removed the assignments to the netdev >> fields mem_start, mem_end and base_addr, which are totally useless >> for PCI devices. >> >> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org> >> -- >> >> drivers/net/e1000/e1000_main.c | 18 +++++------------- >> 1 file changed, 5 insertions(+), 13 deletions(-) > > Looks good to me. auke? yes, please apply. Acked-by: Auke Kok <auke-jan.h.kok@...el.com> Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists