netdev - Re: [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Nov 2007 11:18:45 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Masahide NAKAMURA <nakam@...ux-ipv6.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space

On Mon, Nov 26, 2007 at 12:03:46PM +0900, Masahide NAKAMURA wrote:
>
> With SMP enabled kernel, I found a lock problem at xfrm_state_walk()
> path with the patch on current net-2.6.25. Its log is "circular locking
> dependency detected".

Thanks.  Ingo Molnar reported that too.

I'm just going to revert this patch for 2.6.24 since we've lived
with this race for so long anyway.

Later I'm going to change the locking order so that we always do
the xfrm_state_lock first before taking the x->lock. The rationale
is that only x->lock is taken on the fast path so we want minimise
its outage while xfrm_state_lock isn't.

In fact another change I want to do even later is to move the
expire timers into a work queue which would let us get rid of the
xfrm_*_lock's altogether.

Hmm, I've been talking about that second item for years :) Anybody
who wants to contribute to either of this is most welcome since
my plate's pretty full already.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html