netdev - Re: [PATCH] sungem: fix napi regression with reset work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1196206124.7157.60.camel@pasglop>
Date:	Wed, 28 Nov 2007 10:28:44 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [PATCH] sungem: fix napi regression with reset work


On Mon, 2007-11-26 at 21:02 +0100, Johannes Berg wrote:
> sungem's gem_reset_task() will unconditionally try to disable NAPI even
> when it's called while the interface is not operating and hence the NAPI
> struct isn't enabled. Make napi_disable() depend on gp->running.
> 
> Also removes a superfluous test of gp->running in the same function.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>
> ---
> Not exactly sure how I got there but I did get stuck in there (sysrq-W)
> when I plugged in the network cable and booted the computer on the other
> end of it... while the interface was down. I would've thought that the
> driver wouldn't even notice the fact that I plugged in the cable while
> the interface is down, but maybe it does. Or it sets up the device
> wrongly at resume time when the interface was down at suspend.
> 
> In any case, this should fix the issue.

Thanks.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html