netdev - Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Nov 2007 22:15:36 -0600
From:	Mike Christie <michaelc@...wisc.edu>
To:	Anil Veerabhadrappa <anilgv@...adcom.com>
CC:	Mike Christie <mchristi@...hat.com>,
	Michael Chan <mchan@...adcom.com>, davem@...emloft.net,
	netdev@...r.kernel.org, open-iscsi@...glegroups.com,
	talm@...adcom.com, lusinsky@...adcom.com, uri@...adcom.com,
	SCSI Mailing List <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

Anil Veerabhadrappa wrote:
>>>> The sysfs bits related to the hba should be use one of the scsi sysfs 
>>>> facilities or if they are related to iscsi bits and are generic then 
>>>> through the iscsi hba
>>> bnx2i needs 2 sysfs entries -
>>> 1. QP size info - this is used to size per connection shared data
>>> structures to issue work requests to chip (login, scsi cmd, tmf, nopin)
>>> and get completions from the chip (scsi completions, async messages,
>>> etc'). This is a iSCSI HBA attribute
>>> 2. port mapper - we can be more flexible on classifying this as either
>>> iSCSI HBA attribute or bnx2i driver global attribute
>>> Can hooks be added to iSCSI transport class to include these?
>>>
>> Which ones were they exactly? I think JamesB wanted only common 
>> transport values in the transport class. If it is driver specific then 
>> it should go on the host or target or device with the scsi_host_template 
>> attrs.
>>
> 
> It's a chicken & egg issue to put "port mapper" sysfs entry in scsi host
> attributes. Application won't see sysfs unless initiator creates an

Sorry for the late response. I was on vacation.

That is only with how you coded it today. I asked you to do something 
like qla4xxx where the session and host are not so closely bound.

> iSCSI session and driver can't create an iSCSI session without a tcp

That is not right with how things are today even. The iscsi_session 
struct can be created before the tcp connection. This was done because 
we thought we were going to have to use only sysfs for all setup and 
management (we ended up netlink and sysfs though).

> port. I was wondering if there is a better way than using IOCTL in this
> situation?
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html