netdev - Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <474D322A.9090207@trash.net>
Date:	Wed, 28 Nov 2007 10:17:30 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Ryousei Takano <takano-ryousei@...t.go.jp>
CC:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	dada1@...mosbay.com, t.kudoh@...t.go.jp
Subject: Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

Ryousei Takano wrote:
> Hi Patrick,
> 
>>>>> +struct tc_psp_qopt
>>>>> +{
>>>>> +	__u32	defcls;
>>>>> +	__u32	rate;
>>>>> +};
>>>> What unit is rate measured in?
>>>>
>>> 'rate' is the transmission rate in bytes per sec.
>>
>> So wouldn't it make sense to use u64 then for 10GBit networks?
>>
> I decided to use u32 after tc_ratespec.rate is u32.
> u32 is large enough for 10Gbit networks, but small for 40Gbit.
> I will use u64, because code becomes simple and consistent.


Right, I was thinking about bits per second :)



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html