netdev - RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1196279532.13230.14.camel@pasglop>
Date:	Thu, 29 Nov 2007 06:52:12 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org,
	Jeff Garzik <jeff@...zik.org>
Subject: RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources


On Wed, 2007-11-28 at 10:47 -0800, Brandeburg, Jesse wrote:
> 
> > The side effect is that I removed the assignments to the netdev
> > fields mem_start, mem_end and base_addr, which are totally useless
> > for PCI devices.
> 
> also, concerning this, ifconfig shows the output of these variables, I
> don't think we want to blatantly remove them, as it is actually removing
> information that is, if not used, at least displayed to user space.

It's not the right place to have that information and there is no
room in the user space field to fit more than 32 bits on 32 bits
platforms so I'd rather remove it. It's really only for ISA drivers that
have user configurable addresses.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html