netdev - Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 21:21:22 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>, andi@...stfloor.org,
	netdev@...r.kernel.org, gerrit@....abdn.ac.uk,
	bfields@...ldses.org, neilb@...e.de
Subject: Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

On Thu, Nov 29, 2007 at 06:08:30PM +0800, Wang Chen wrote:
> 
> Add a new UdpInEarlyDatagrams counter to count datagrams received early,
> but which might be dropped later.

Could you please split this into two patches? Have one do the
UdpInDatagrams change and the other to introduce the EarlyDatagrams
counter.

I'm a bit hesitant to introduce new counters in the MIB because
it'd be difficult if not impossible to ever remove them.  Do you
really need the early counter?

One more thing, please put the is_udplite clean-up in its own
patch too so it's absolutely clear what we're changing in the
patches that aren't clean-ups.

> Signed-off-by: Andi Kleen <ak@...e.de>
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Who's the author? Andi or you? Please make this obvious with a From
header when you resubmit.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html