netdev - Re: [PATCH 4/3] net/bonding: Adhere to coding style: break line after the if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <474E0F63.5060702@oracle.com>
Date:	Wed, 28 Nov 2007 17:01:23 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Ferenc Wágner <wferi@...f.hu>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 4/3] net/bonding: Adhere to coding style: break line after
 the if condition

=?utf-8?q?Ferenc_W=C3=A1gner?= wrote:
> Signed-off-by: Ferenc Wágner <wferi@...f.hu>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
> Randy Dunlap <randy.dunlap@...cle.com> writes:
> 
>  drivers/net/bonding/bond_sysfs.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
> index 5c31f5c..9de2c52 100644
> --- a/drivers/net/bonding/bond_sysfs.c
> +++ b/drivers/net/bonding/bond_sysfs.c
> @@ -91,7 +91,8 @@ static ssize_t bonding_show_bonds(struct class *cls, char *buf)
>  		}
>  		res += sprintf(buf + res, "%s ", bond->dev->name);
>  	}
> -	if (res) buf[res-1] = '\n'; /* eat the leftover space */
> +	if (res)
> +		buf[res-1] = '\n'; /* eat the leftover space */
>  	up_read(&(bonding_rwsem));
>  	return res;
>  }
> @@ -239,7 +240,8 @@ static ssize_t bonding_show_slaves(struct device *d,
>  		res += sprintf(buf + res, "%s ", slave->dev->name);
>  	}
>  	read_unlock(&bond->lock);
> -	if (res) buf[res-1] = '\n'; /* eat the leftover space */
> +	if (res)
> +		buf[res-1] = '\n'; /* eat the leftover space */
>  	return res;
>  }
>  
> @@ -705,7 +707,8 @@ static ssize_t bonding_show_arp_targets(struct device *d,
>  			res += sprintf(buf + res, "%u.%u.%u.%u ",
>  			       NIPQUAD(bond->params.arp_targets[i]));
>  	}
> -	if (res) buf[res-1] = '\n'; /* eat the leftover space */
> +	if (res)
> +		buf[res-1] = '\n'; /* eat the leftover space */
>  	return res;
>  }
>  


-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html