netdev - Re: [PATCH 2/2] Eliminate unused argument from sk_stream_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071129102325.GB22537@gondor.apana.org.au>
Date:	Thu, 29 Nov 2007 21:23:25 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	Linux Netdev List <netdev@...r.kernel.org>, devel@...nvz.org
Subject: Re: [PATCH 2/2] Eliminate unused argument from sk_stream_alloc_pskb

On Mon, Nov 26, 2007 at 08:17:27PM +0300, Pavel Emelyanov wrote:
> The 3rd argument is always zero (according to grep :) Eliminate
> it and merge the function with sk_stream_alloc_skb.
> 
> This saves 44 more bytes, and together with the previous patch
> we have:
> 
> add/remove: 1/0 grow/shrink: 0/8 up/down: 183/-751 (-568)
> function                                     old     new   delta
> sk_stream_alloc_skb                            -     183    +183
> ip_rt_init                                   529     525      -4
> arp_ignore                                   112     107      -5
> __inet_lookup_listener                       284     274     -10
> tcp_sendmsg                                 2583    2481    -102
> tcp_sendpage                                1449    1300    -149
> tso_fragment                                 417     258    -159
> tcp_fragment                                1149     988    -161
> __tcp_push_pending_frames                   1998    1837    -161

Also applied to net-2.6.25.  Thanks.

> Question: is this 2.6.24 material (good space saving) or should I
> rework this against 2.6.25 (it applies with fuzzes, but seems to
> compile)?

I guess I've answered this question :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html